Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate section pages in list fragment #755

Merged
merged 1 commit into from
May 4, 2020
Merged

Fix duplicate section pages in list fragment #755

merged 1 commit into from
May 4, 2020

Conversation

mpourismaiel
Copy link
Member

What this PR does / why we need it:
.Pages previously only returned pages with .Kind eq "page" but now it returns all pages under a section. Changed our list helper to collect pages based on their .Kind if subsections is not set or is set to false.

Which issue this PR fixes:
fixes #751

Release note:

- list: Fix a bug that caused subsections be shown if the config was set to not show them or show duplicate subsections if config was set to show them.

@mpourismaiel mpourismaiel added this to the v0.18.0 milestone May 4, 2020
@mpourismaiel mpourismaiel requested a review from stp-ip May 4, 2020 05:18
@mpourismaiel mpourismaiel self-assigned this May 4, 2020
@mpourismaiel
Copy link
Member Author

A good place to check this out: /dev/list/.

@stp-ip stp-ip merged commit 8bdc869 into okkur:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stp-ip stp-ip stp-ip approved these changes

Assignees

@mpourismaiel mpourismaiel

Labels
bug
Milestone
v0.17.1
Development

Successfully merging this pull request may close these issues.

Investigate duplicate pages within list
2 participants
@mpourismaiel @stp-ip